FlowRouter Support#343
Open
AlexeyMK wants to merge 8 commits into
Open
Conversation
|
How well does this work? I'm still on the lookout for a no-config admin solution. |
|
The intention of this PR is good, but unfortunately I think it was not tested. When I go to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Still WIP]
@gterrono, looks like MDG is leaning towards just supporting FlowRouter. For Houston to work with FlowRouter is a non-trivial rewrite, since we rely on template data context and router level subscriptions pretty heavily and FlowRouter doesn't particularly like that approach.
That said, an (as you can see) temporary hack includes just passing
datathrough anyway.A bunch of stuff is still broken (had a few hours during a hackday to poke at this) but figured I'd share and see if you or others had time to contribute.