Draft
Conversation
This is just a bool.
Otherwise we return early when the version in the gir does not specify, e.g. the patch version.
This was missed during the port to gir-parser.
Closed
| @@ -477,16 +482,16 @@ fn detect_length<'a>( | |||
| } | |||
|
|
|||
| fn is_length(par: &library::Parameter) -> bool { | |||
Member
There was a problem hiding this comment.
This is something we could add to upstream gir-parser btw.
Member
|
I will try to have a look at this tomorrow and hopefully we can land it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is able already to generate graphene's bindings without any difference to the current version with
python generator.py graphene.As far as I know, the remaining issues are related to the read_array and read_type fns. These can be seen on e.g. pango bindings. See #1577 (comment).
Continuation of #1577.