Add gio::File, gio::FileEnumerator, gio::FileMonitor, gio::Vfs subclasses#1676
Merged
Conversation
Member
|
Very interesting, thanks! OOC, what are you planning to implement with this? |
sdroege
reviewed
Mar 4, 2025
sdroege
reviewed
Mar 4, 2025
sdroege
reviewed
Mar 4, 2025
Member
|
Just shortly looked over it, will do a proper review one of these days but generally it looks correct. |
fbrouille
force-pushed
the
gio_file_subclass
branch
from
94aacc1 to
bbfa6db
Compare
fbrouille
force-pushed
the
gio_file_subclass
branch
from
bbfa6db to
ce47c8b
Compare
Contributor
Author
|
OOC I'm planning to implement some nautilus extension in Rust (very challenging 😅) |
Member
|
would you mind rebasing & finishing the small remaining bits here? |
Contributor
Author
|
Yes, I'm adding subclass/file.rs (with almost all vfuncs), tests and a complete example to show how to implement a custom Vfs. I will share it during next week. |
fbrouille
force-pushed
the
gio_file_subclass
branch
from
ce47c8b to
b4e9183
Compare
fbrouille
changed the title
fbrouille
force-pushed
the
gio_file_subclass
branch
9 times, most recently
from
e9842cc to
10bb6d0
Compare
fbrouille
force-pushed
the
gio_file_subclass
branch
2 times, most recently
from
260cf0e to
0cb4a44
Compare
fbrouille
force-pushed
the
gio_file_subclass
branch
from
0cb4a44 to
a0345a9
Compare
fbrouille
force-pushed
the
gio_file_subclass
branch
from
bb64921 to
5852352
Compare
fbrouille
force-pushed
the
gio_file_subclass
branch
from
5852352 to
90806e8
Compare
fbrouille
force-pushed
the
gio_file_subclass
branch
from
90806e8 to
ab017fe
Compare
Member
|
What's the status of this? Is this ready? |
fbrouille
force-pushed
the
gio_file_subclass
branch
from
ab017fe to
21c0c0f
Compare
Contributor
Author
|
Rebased and ready. Let me know if you’d prefer I split this into separate PRs. |
fbrouille
force-pushed
the
gio_file_subclass
branch
from
21c0c0f to
4bd8355
Compare
Contributor
Author
|
Intermittent failure in the |
sdroege
reviewed
Jan 14, 2026
sdroege
reviewed
Jan 14, 2026
sdroege
reviewed
Jan 14, 2026
sdroege
reviewed
Jan 14, 2026
sdroege
reviewed
Jan 14, 2026
fbrouille
force-pushed
the
gio_file_subclass
branch
2 times, most recently
from
cf37a47 to
8638234
Compare
Contributor
Author
|
Rebased and ready. |
sdroege
previously approved these changes
Jan 17, 2026
sdroege
left a comment
sdroege
left a comment
Member
There was a problem hiding this comment.
Good for me apart from what @bilelmoussaoui already wrote.
fbrouille
force-pushed
the
gio_file_subclass
branch
from
8638234 to
f6fbb4b
Compare
Signed-off-by: fbrouille <fbrouille@users.noreply.github.com>
Signed-off-by: fbrouille <fbrouille@users.noreply.github.com>
Signed-off-by: fbrouille <fbrouille@users.noreply.github.com>
Signed-off-by: fbrouille <fbrouille@users.noreply.github.com>
fbrouille
force-pushed
the
gio_file_subclass
branch
from
f6fbb4b to
3f7fbc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow custom implementation of gio::Vfs, gio::File, gio::FileEnumerator and gio::FileMonitor