Enable strict provenance lints on nightly#1918
Open
carlosmn wants to merge 2 commits into
Open
Conversation
carlosmn
force-pushed
the
cmn/nightly-sa-lints
branch
from
9103ce9 to
cb953a9
Compare
These are only allowed on nightly so we can't just enable them.
Most of the tests run with `--all-features` so the feature will be on by default but graphene and pango don't so we add it explicitly.
carlosmn
force-pushed
the
cmn/nightly-sa-lints
branch
from
cb953a9 to
ffa6f2c
Compare
Member
|
That this needs a feature flag etc is adding quite a bit of noise just for testing purposes. I'm not sure that's a good idea for maintainability |
Contributor
Author
|
I did end up wondering if it's worth doing all of this. Once the lints become stable presumably you can detect this via clippy for some time. |
Member
|
Let's do that then and keep this open here for now as reminder :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up from #1917 (and in service to #659) here we add the feature
strict-provenancethat enables these lints. You can only enable them behind a nightly flag so we also have to put it behind a flag.A bunch of these tests already enable all flags on nightly so we're covered there but those are for specific subprojects, so I've also added it to the general
cargo buildthat runs on nightly.