Skip to content

gio: Add "D-Bus" and "DBus" to Cargo.toml keywords and description#1935

Merged
bilelmoussaoui merged 1 commit into
gtk-rs:mainfrom
martn3:dbus-keywords
Mar 31, 2026
Merged

gio: Add "D-Bus" and "DBus" to Cargo.toml keywords and description#1935
bilelmoussaoui merged 1 commit into
gtk-rs:mainfrom
martn3:dbus-keywords

Conversation

@martn3

@martn3 martn3 commented Mar 25, 2026

Copy link
Copy Markdown

One good way to keep Rust binary sizes down when using D-Bus is to use gio’s D-Bus bindings and link dynamically to the system libgio-2.0.so.

However, if you’re not already aware that gio provides D-Bus bindings, it’s hard to discover that it does. For example, searching for "dbus" on https://crates.io/ does not list gio as an alternative.

This commit addresses that by including the terms "D-Bus" and "DBus" in the gio package keywords and description. We include both "D-Bus" and "DBus" because that’s what other D-Bus crates, such as dbus and zbus, also do.

Steps to reproduce the problem this commit should fix

  1. Go to https://crates.io/search?q=dbus&sort=downloads

Expected result

gio is listed on the first page.

Actual result

gio is not listed at all, despite having enough total downloads to qualify for the top 10 results.

Comment thread gio/Cargo.toml Outdated
One good way to keep Rust binary sizes down when using D-Bus is to use
`gio`’s D-Bus bindings and link dynamically to the system
`libgio-2.0.so`.

However, if you’re not already aware that `gio` provides D-Bus bindings,
it’s hard to discover that it does. For example, searching for "dbus" on
https://crates.io/ does not list `gio` as an alternative.

This commit addresses that by including the terms "D-Bus" and "DBus" in
the `gio` package keywords and description. We include both "D-Bus" and
"DBus" because that’s what other D-Bus crates, such as [`dbus`][1] and
[`zbus`][2], also do.

  ### Steps to reproduce
  1. Go to https://crates.io/search?q=dbus&sort=downloads

  ### Expected result
  `gio` is listed on the first page.

  ### Actual result
  `gio` is not listed at all, despite having enough total downloads to
  qualify for the top 10 results.

[1]: https://github.com/diwic/dbus-rs/blob/eee6bf5b2d9ff81fabd281cb24b222455f2b5919/dbus/Cargo.toml#L10C12-L10C28
[2]: https://github.com/z-galaxy/zbus/blob/3d3491dabe1914b619305e56e856b5c3555cca1b/zbus/Cargo.toml#L10C12-L10C36
@bilelmoussaoui bilelmoussaoui added the needs-backport PR needs backporting to the current stable branch label Mar 25, 2026
@martn3

martn3 commented Mar 26, 2026

Copy link
Copy Markdown
Author

Just checking: am I expected to do something before this can be merged? I've noticed CI fails for example, but that does not seem to be caused by this PR?

@bilelmoussaoui bilelmoussaoui merged commit 19bf039 into gtk-rs:main Mar 31, 2026
31 of 58 checks passed
@sdroege sdroege added backported PR was backported to the current stable branch and removed needs-backport PR needs backporting to the current stable branch labels Apr 5, 2026
@sdroege

sdroege commented Apr 5, 2026

Copy link
Copy Markdown
Member

the remote server responded with an error (status 400 Bad Request): expected at most 5 keywords per crate

Oh no :)

@sdroege sdroege added needs-backport PR needs backporting to the current stable branch and removed backported PR was backported to the current stable branch labels Apr 5, 2026
@sdroege

sdroege commented Apr 5, 2026

Copy link
Copy Markdown
Member

Please decide which ones you want to keep, I release without this for now.

@martn3

martn3 commented Apr 7, 2026

Copy link
Copy Markdown
Author

Oh no, indeed :)

Fixed by #1946.

@martn3 martn3 deleted the dbus-keywords branch April 7, 2026 06:21
@sdroege sdroege added backported PR was backported to the current stable branch and removed needs-backport PR needs backporting to the current stable branch labels Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported PR was backported to the current stable branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants