0.22 backports#1945
Merged
Merged
Conversation
…t in `MainContext::block_on()` Everything else leads to hard to debug issues and was already documented before as invalid usage.
Regression from the commit: 27e19a8 The function must be always exported for windows
One good way to keep Rust binary sizes down when using D-Bus is to use `gio`’s D-Bus bindings and link dynamically to the system `libgio-2.0.so`. However, if you’re not already aware that `gio` provides D-Bus bindings, it’s hard to discover that it does. For example, searching for "dbus" on https://crates.io/ does not list `gio` as an alternative. This commit addresses that by including the terms "D-Bus" and "DBus" in the `gio` package keywords and description. We include both "D-Bus" and "DBus" because that’s what other D-Bus crates, such as [`dbus`][1] and [`zbus`][2], also do. ### Steps to reproduce 1. Go to https://crates.io/search?q=dbus&sort=downloads ### Expected result `gio` is listed on the first page. ### Actual result `gio` is not listed at all, despite having enough total downloads to qualify for the top 10 results. [1]: https://github.com/diwic/dbus-rs/blob/eee6bf5b2d9ff81fabd281cb24b222455f2b5919/dbus/Cargo.toml#L10C12-L10C28 [2]: https://github.com/z-galaxy/zbus/blob/3d3491dabe1914b619305e56e856b5c3555cca1b/zbus/Cargo.toml#L10C12-L10C36
… the parent class/interface is deprecated Fixes gtk-rs#1941
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.