main_event_loop.md: Port ashpd features from async-std to async-io#2273
Open
ratijas wants to merge 3 commits into
Open
main_event_loop.md: Port ashpd features from async-std to async-io#2273ratijas wants to merge 3 commits into
ratijas wants to merge 3 commits into
Conversation
`async-std` is no longer a feature of `ashpd` crate, and `async-io` replaced it. In fact, the whole `async-std` is deprecated in favor of `smol`.
Author
|
Looking into #[cfg(all(all(feature = "tokio", feature = "async-io"), not(doc)))]
compile_error!("You can't enable both async-io & tokio features at once");
#[cfg(all(not(feature = "tokio"), not(feature = "async-io"), not(doc)))]
compile_error!("Either the `async-io` or the `tokio` feature has to be enabled");I don't know the whole story, but it looks like Also, #[cfg_attr(docsrs, doc(cfg(feature = "account")))]
#[cfg(feature = "account")]
pub mod account; |
The module `ashpd::desktop::account` is feature-gated.
Author
|
Also the example uses
|
The `reqwest@0.13` has brought some breaking changes in its feature names: > `rustls` is now the default TLS backend, instead of `native-tls`. > `rustls-tls` has been renamed to `rustls`.
Collaborator
|
Can you please check this out @bilelmoussaoui? |
Author
|
There are couple more recommendations of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
async-stdis no longer a feature ofashpdcrate, andasync-ioreplaced it. In fact, the wholeasync-stdis deprecated in favor ofsmol.