fix: corrects the GCS credentials flag in command examples - #3195
Merged
Conversation
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
gaganhr94
force-pushed
the
fix-gcs-example-credentials-flag
branch
from
August 29, 2026 16:11
ec4093a to
3596aa9
Compare
The Example strings for both gcs commands advertised a --gcs-credentials-path flag, which is not registered. pkg/cli/store.go registers gcp-credentials-path, and the constant declared two lines above each example already held the correct value. Copying the example out of --help failed with "unknown flag". The guaccollect example also invoked "guacone collect gcs". guaccollect registers gcs as a top-level subcommand and has no collect grouping, so that is corrected to "guaccollect gcs". Fixes #3193 Signed-off-by: gaganhr94 <hrgagan4@gmail.com>
gaganhr94
force-pushed
the
fix-gcs-example-credentials-flag
branch
from
August 29, 2026 16:19
3596aa9 to
136ea18
Compare
mihaimaruseac
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3193.
The
Example:strings on bothgcscommands advertised a--gcs-credentials-pathflag. That flag is not registered —pkg/cli/store.go:130registers
gcp-credentials-path— so copying the example out of--helpfailedwith
unknown flag. ThegcsCredentialsPathFlagconstant declared two linesabove each example already held the correct value, so this is only the literal
in the example drifting from it.
Two changes:
cmd/guaccollect/cmd/gcs.go:34andcmd/guacone/cmd/gcs.go:54:--gcs-credentials-path->--gcp-credentials-path.cmd/guaccollect/cmd/gcs.go:34also invokedguacone collect gcs.guaccollectregistersgcsas a top-level subcommand (rootCmd.AddCommand(gcsCmd),line 143) and has no
collectgrouping, so the binary and path are correctedto
guaccollect gcs.Verified:
go build ./cmd/...,go vetandgo teston both changed packagesall pass.
cmd/guacone/cmd/gcs_test.go:37already asserts the correct flag namein its error text, so the tests agreed with the fix before this change.
The same typo had propagated into the docs; fixed in guacsec/guac-docs#244.