test(git): remove network and git layout dependencies - #3197
Open
CAOShurong wants to merge 1 commit into
Open
Conversation
Signed-off-by: CAOShurong <170531907+CAOShurong@users.noreply.github.com>
mihaimaruseac
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the PR
This removes two sources of nondeterminism from the Git collector test:
.gitimplementation files;A recent integration run (32978753396, job 98209847685) timed out after collecting 0 files. On the current base, the polling subtest also failed 20/20 local runs because the checkout contained 10 files while the test hard-coded 9. The updated test passed 50 consecutive runs.
This addresses one source of the integration-test flakiness tracked in #2930. It intentionally does not change production collector behavior.
Validation
go test ./pkg/handler/collector/git -count=50git diff HEAD^ HEAD --checkThe broader collector suite still has pre-existing Windows-only path-separator failures in the file collector tests; those reproduce unchanged on the base commit and are outside this PR.
Implementation and investigation were assisted by OpenAI Codex. I reviewed the diff and ran the validation above.
PR Checklist
git commit -s.collectsubprotobuf is unchanged