fix: update npm before npm ci in CI workflows#427
Merged
a-oren merged 1 commit intoguacsec:mainfrom Mar 24, 2026
Merged
Conversation
Review Summary by QodoUpdate npm before npm ci in CI workflows
WalkthroughsDescription• Add npm version update step before npm ci in three CI workflows • Resolves npm bug with conflicting --prefer-offline and --prefer-online flags • Ensures consistent npm version across all CI pipeline stages • Extends existing workaround from publish.yml to test, release, and push-to-registry workflows Diagramflowchart LR
A["CI Workflows"] --> B["Setup Node 24"]
B --> C["Install latest npm"]
C --> D["npm ci"]
D --> E["Build/Test/Deploy"]
File Changes1. .github/workflows/push-to-registry.yml
|
Code Review by Qodo
1. Unpinned npm in CI
|
344e00f to
89b8421
Compare
ruromero
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The npm bundled with Node 24 (and now Node 22) has a bug where it passes conflicting
--prefer-offlineand --prefer-onlineflags internally when installing git dependencies, causing npm ci to fail.This pins npm to 11.11.1 (last known working version) across all CI workflows before running npm ci.
Related issues (if any):
Checklist
Additional information