Skip to content

✨ WIP Nodejs22 upgrade#372

Closed
carlosthe19916 wants to merge 3 commits intoguacsec:mainfrom
carlosthe19916:nodejs22
Closed

✨ WIP Nodejs22 upgrade#372
carlosthe19916 wants to merge 3 commits intoguacsec:mainfrom
carlosthe19916:nodejs22

Conversation

@carlosthe19916
Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
@gildub
Copy link
Copy Markdown
Contributor

gildub commented Feb 24, 2025

Closing/Opening PR to kick CI again.

@gildub gildub reopened this Feb 24, 2025
@gildub
Copy link
Copy Markdown
Contributor

gildub commented Feb 24, 2025

@carlosthe19916, thanks for bringing that one which allowed to compare with my PR.
This PR seems to be working but I believe the packages have not been fully updated.
The main reason is that "@hey-api/client-axios": "^0.2.7" and "@hey-api/openapi-ts": "^0.53.5" don't support nodejs 22.

@carlosthe19916
Copy link
Copy Markdown
Collaborator Author

@carlosthe19916, thanks for bringing that one which allowed to compare with my PR. This PR seems to be working but I believe the packages have not been fully updated. The main reason is that "@hey-api/client-axios": "^0.2.7" and "@hey-api/openapi-ts": "^0.53.5" don't support nodejs 22.

If your intention or blocker is the hey-api dependency i suggest you to upgrade only hey-api in a separate independent PR before you tackle the NodejS 22 thing. As I am sure the very latest version of hey-api contains breaking changes https://heyapi.dev/openapi-ts/migrating

@carlosthe19916
Copy link
Copy Markdown
Collaborator Author

Closing this PR as this was just to share knowledge, the real work will be covered at #328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants