Add support to latest NodeJS LTS version#328
Conversation
5d14ac8 to
75b86de
Compare
carlosthe19916
left a comment
There was a problem hiding this comment.
The test are failing. And it is due to the changes in this PR. See this other test PR I created #330 , the tests are passing but they fail here. https://github.com/trustification/trustify-ui-tests has quite a simple test so there is something wrong with this PR. Please clone that repo and make sure this PR does not break that basic test... on a side note, I am happy that we have the e2e tests even at a basic level, we can capture these kind of things, that hopefully those test will get even better.
On the other hand. If I execute:
npm run start:devIn a clean environment I get the error:
Cannot find module '@app/client' or its corresponding type declarations
That is caused because we are not including client/src/app/client/ anymore. While I see the reason behind ignoring that folder, seems like it is not actually solving a problem but creating one.
|
@gildub here is the PR I mentioned internally before #372 Feel free to close my PR and take it just as an example. I don't want to step of your toes, just to share what I have discovered while playing with it. |
carlosthe19916
left a comment
There was a problem hiding this comment.
@gildub This is my environment
NodeJS v22.14.0
NPM v10.9.2
I checkout this PR. Then
npm ci --ignore-scriptsThen
npm run start:devScreencast.From.2025-02-25.15-38-23.mp4
- The dev mode is broken
- Clearly the ci pipeline fails for a reason
|
@carlosthe19916, this is ready to go, please confirm. |
Give me some time please. |
carlosthe19916
left a comment
There was a problem hiding this comment.
LGTM!
We need to synchronize this important change here https://gitlab.cee.redhat.com/trustification/rhtpa-konflux-release.0.2.z/-/blob/main/Dockerfile.server?ref_type=heads#L4
@gildub could you take care of it please?
- First the downstream image needs to be changed.
- Only after it this PR can be merged otherwise we will destroy the downstream pipeline
NodeJS 22 is LTS
Fix #327