Conversation
gildub
left a comment
There was a problem hiding this comment.
@carlosthe19916, similarly as the Vite solution, it removes 21,000 lines of code and adds about 10,500 lines, even better than vite.
Did you use the migration option to convert from Webpack ?
No i didn't. I did all changes manually. Rsbuild contains a lot of "out of the box" configuration similar to Vite, and I did this POC with that. |
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
# Conflicts: # client/package.json # package-lock.json # package.json
|
@gildub I made minor changes recently to this PR so it is now ready to be reviewed. Whenever you have time, feel free to look at it for the second time :) |
| export const AnalyticsContextProvider: React.FC<IAnalyticsProviderProps> = ({ | ||
| children, | ||
| }) => { | ||
| /* eslint-disable react-hooks/rules-of-hooks */ |
There was a problem hiding this comment.
Biome doesn't use eslint stanza style.
Shouldn't that one be replace with // biome-ignore lint/react-hooks-rules-of-hooks ?
There was a problem hiding this comment.
@gildub I removed the changes this PR was doing in regards of adding comments like /* eslint-disable react-hooks/rules-of-hooks */ As you correctly mentioned it should be replaced by the Biome style.
We will need to do the migration in 2 steps:
- First step: this PR
- Second step: enable the biome lint and format rules in our CI and while doing it add the appropriate
/* eslint-disable react-hooks/rules-of-hooks */or similar rules. At the moment we don't enable our Eslint rules in CI either.
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.