Skip to content

👻 Apply Biome Lint Rules and enforce them in CI#409

Merged
gildub merged 10 commits intoguacsec:mainfrom
carlosthe19916:biome-lint
Mar 25, 2025
Merged

👻 Apply Biome Lint Rules and enforce them in CI#409
gildub merged 10 commits intoguacsec:mainfrom
carlosthe19916:biome-lint

Conversation

@carlosthe19916
Copy link
Copy Markdown
Collaborator

Resolves #340

Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
# Conflicts:
#	client/src/app/components/FilterPanel/CheckboxFilterControl.tsx
#	client/src/app/components/FilterToolbar/MultiselectFilterControl.tsx
#	client/src/app/queries/advisories.ts
#	client/src/app/queries/importers.ts
#	client/src/app/queries/packages.ts
#	client/src/app/queries/sboms.ts
#	client/src/app/queries/vulnerabilities.ts
#	server/src/index.ts
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
@trust-git-bot
Copy link
Copy Markdown

trust-git-bot commented Mar 22, 2025

🚀 Storybook Deployed Preview: https://trustify-ui-pr-409-preview.surge.sh

Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
@carlosthe19916 carlosthe19916 requested a review from gildub March 22, 2025 12:06
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
@carlosthe19916 carlosthe19916 self-assigned this Mar 22, 2025
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@gildub gildub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice.

Just some suggestions to avoid any as much as possible and get rid of biome-ignore along.

responseType: "arraybuffer",
headers: { Accept: "text/plain", responseType: "blob" },
}).then((response) => {
// biome-ignore lint/suspicious/noExplicitAny:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
@carlosthe19916 carlosthe19916 requested a review from gildub March 25, 2025 08:43
@carlosthe19916
Copy link
Copy Markdown
Collaborator Author

@gildub Thanks for the review. I addressed your comments. Feel free to look at this PR again :)

@gildub gildub merged commit 9b3c459 into guacsec:main Mar 25, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enforce eslint rules

3 participants