✨ Add Score to Severity shield component#416
Merged
gildub merged 4 commits intoguacsec:mainfrom Mar 27, 2025
Merged
Conversation
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
# Conflicts: # client/src/app/pages/advisory-list/advisory-table.tsx # client/src/app/pages/package-details/vulnerabilities-by-package.tsx
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
carlosthe19916
changed the title
Collaborator
Author
|
The backend solved guacsec/trustify#1473 already so this PR is ready to be reviewed |
gildub
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #415
The User Stories Review done days ago revealed that due to v1 UI Parity we need to render, for each severity, the numeric score next to it.
https://issues.redhat.com/browse/TC-2200 is one of the tickets that highlighted it.
For consistency this PR changes in a single PR all pages that renders Severities. Each severity will look like
Shield with color + Severity Name + (Severity numeric Score).This PR is in progress and we will need to wait for guacsec/trustify#1473 to be fixed as 2 endpoints do not contain the numeric score value for a Severity