Skip to content

🐛 align Severity & Score nullable fields #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlosthe19916 merged 1 commit into from
May 5, 2025
Merged

🐛 align Severity & Score nullable fields #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions client/src/app/pages/advisory-details/vulnerabilities-by-advisory.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
Tr,
} from "@patternfly/react-table";

import { extendedSeverityFromSeverity } from "@app/api/models";
import type { AdvisoryVulnerabilitySummary } from "@app/client";
import { SeverityShieldAndText } from "@app/components/SeverityShieldAndText";
import { SimplePagination } from "@app/components/SimplePagination";
Expand Down Expand Up @@ -160,8 +161,8 @@ export const VulnerabilitiesByAdvisory: React.FC<
>
{item.severity && (
<SeverityShieldAndText
value={item.severity}
score={item.score}
value={extendedSeverityFromSeverity(item.severity)}
score={item.score ?? null}
showLabel
showScore
/>
Expand Down
4 changes: 3 additions & 1 deletion client/src/app/pages/advisory-list/advisory-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,9 @@ export const AdvisoryTable: React.FC = () => {
>
{item.average_severity && (
<SeverityShieldAndText
value={item.average_severity as Severity}
value={extendedSeverityFromSeverity(
item.average_severity as Severity,
)}
score={item.average_score}
showLabel
showScore
Expand Down
2 changes: 1 addition & 1 deletion client/src/stories/v2.1/pages/search.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ export const SearchPage: React.FC = () => {
<Split>
<SplitItem isFilled>{item.name}</SplitItem>
<SplitItem>
<SeverityShieldAndText value="medium" hideLabel />
<SeverityShieldAndText value="medium" score={5} />
</SplitItem>
</Split>
</CardTitle>
Expand Down
2 changes: 2 additions & 0 deletions client/src/stories/v2.1/product-list.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ const ProductList: React.FC<{ products: IProduct[] }> = ({ products }) => {
{vuln.average_severity && (
<SeverityShieldAndText
value={vuln.average_severity}
score={5}
/>
)}
</Td>
Expand Down Expand Up @@ -311,6 +312,7 @@ const ProductList: React.FC<{ products: IProduct[] }> = ({ products }) => {
{adv.average_severity && (
<SeverityShieldAndText
value={adv.average_severity}
score={5}
/>
)}
</Td>
Expand Down
Loading