fix: cubism2 automatic eye blink is not working properly - #175
Open
TSKI433 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这个问题可以通过加载一个cubism2的模型,然后确保模型没有载入idle动作来复现。
cubism2的自动眨眼状态机中,Closing的一个正负号弄反了,导致状态机没有继续往下走。
修复完成后发现还有个问题,模型在闭眼到底后,会有一帧突然睁眼,然后下一帧立马恢复到闭眼,又逐渐睁眼。
用数字描述就是:
1
0.8
0.6
0.4
0.2
0
1
0.2
0.4
0.6
0.8
1
根据我的测试,可能跟cubism2中core内部的一些逻辑有关,当我取消update中调用model.loadParam()时,该问题消失了。
目前我的解决方案是,在Closed状态下也进行setEyeParams的调用