Misc rework - possibly improved stability#166
Open
e2 wants to merge 7 commits into
Open
Conversation
| expect(Guard::Compat::UI).to receive(:deprecation).with(/:js_default_extra_wait_time is deprecated. Check out :js_options/) | ||
| subject | ||
| end | ||
|
|
There was a problem hiding this comment.
Extra empty line detected at block body end.
|
I've been testing this a bit and it fixes a persistent issue I've been having with 100% CPU utilization in my guard process. Possibly related to having multiple browser tabs open, stopping in the JS debugger, etc.? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch mentioned here: #150 (comment)
Should be considered for merging.
(Please let me know if this helps fix your issues and I'll be glad to release it if so).