chore(deps): bump @types/node from 22.15.30 to 26.1.0#2926
chore(deps): bump @types/node from 22.15.30 to 26.1.0#2926dependabot[bot] wants to merge 3 commits into
Conversation
dependabot
Bot
added
dependencies
|
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/types/node-26.1.0
branch
from
cf8c6d5 to
f52186c
Compare
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.15.30 to 26.1.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 26.1.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/types/node-26.1.0
branch
from
f52186c to
fe5b63c
Compare
| .findAll() | ||
| .filter((construct) => construct instanceof CfnParameter) | ||
| .reduce((acc, param) => ({ ...acc, [param.node.id]: param as CfnParameter }), {}); | ||
| .reduce((acc, param) => ({ ...acc, [param.node.id]: param }), {}); |
There was a problem hiding this comment.
@akash1810 upgrading the typescript version has been on our radar for a while (https://app.asana.com/1/1210045093164357/project/1214113788426225/task/1214114210834985) I had a go with an AI agent and it appears the code change we need is a nice simplification: we no longer need to cast these types. What do you reckon? Is a green CI build here sufficient to know it's good? Can this cause problems to clients or anything like that?
There was a problem hiding this comment.
Oh perfect! Removing this cast is preferable; the function's return type should be enough as should the instanceof in the previous filter.
Bumps @types/node from 22.15.30 to 26.1.0.
Commits