Tidy-up tests, introduce LoadingTest.TestApparatus & TestFetching.withStubDataStore #118
Merged
Tidy-up tests, introduce LoadingTest.TestApparatus & TestFetching.withStubDataStore #118
LoadingTest.TestApparatus & TestFetching.withStubDataStore #118Conversation
rtyley
commented
Oct 9, 2025
Comment on lines
-25
to
+80
| TolerateOldValueWhileRefreshing, | ||
| _.maximumSize(1).refreshAfterWrite(100.millis) | ||
| testApparatus.loading.onUpdate(update => updates.append(update)), | ||
| AlwaysWaitForRefreshedValue, |
Member
Author
There was a problem hiding this comment.
This test ("provide callbacks that allow logging updates") was previously testing a bit more than just the target functionality, so it was more complex than it needed to be.
Switching to a FreshnessPolicy of AlwaysWaitForRefreshedValue (rather than TolerateOldValueWhileRefreshing) simplifies things because it means we always will receive the latest value, and don't need to add in artificial delays in order to get the right value.
0bb7706 to
c3dc18a
Compare
c3dc18a to
271b674
Compare
TestFetching.withLookupLoadingTest.TestApparatus & TestFetching.withStubDataStore
jonathonherbert
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These improvements are partially motivated by the changes in this PR:
...as that PR adds a
fetching.thenParsingWithKey()method to complementfetching.thenParsing(), it's good to tidy up the test forthenParsing()first, to make the subsequent introduction of testing on the sister-methodthenParsingWithKey()method nice & small.Changes
com.gu.etagcaching.testkitpackage to contain useful functionality for testsCountingParser- a parser that counts how many times it's used, so we can test we're not doing any unnecessary parsingTestFetchingmoves into thetestkitpackage, and gainsTestFetching.withStubDataStoreto let us create stubFetchinginstances that will return whatever data we choose.LoadingTest.TestApparatusadded, to keep the checks for unnecessary-parsing concise.