HMAC auth check #28266
Closed
HMAC auth check #28266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
frederickobrien
force-pushed
the
hmac-auth-check
branch
from
3f38760 to
670caa4
Compare
Co-Authored-By: Jonathon Herbert <[email protected]>
frederickobrien
force-pushed
the
hmac-auth-check
branch
from
670caa4 to
37ec527
Compare
Contributor
Author
|
Following a chat with @JamieB-gu and @arelra a few open questions:
Also plan to have a chat with @rtyley to better understand how HMAC sits in panda auth checks. |
Contributor
Author
|
Closing as we've opted for a different approach (#28328). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a HMAC auth check to the preview project. This is part of work on a live harness service for interactive atom development. We've added
awsSecretsManagerandpanDomainHMACas dependencies and added a HMAC fork inGuardianAuthWithExceptionsthat validates HMAC requests.We want to be able to hit preview and this allows us to do so in a way that's consistent with existing auth checks.