Skip to content

Conversation

@ioannakok
Copy link
Contributor

@ioannakok ioannakok commented Oct 9, 2025

Closes #28260

What does this change?

Checklist

  • Tested locally, and on CODE if necessary
  • Will not break dotcom-rendering
  • No need for new test data/database files
  • No need for accessibility testing

The project is no longer maintained: https://github.com/FluentLenium/FluentLenium

oe are removing FluentLenium because the project is no longer maintained. https://github.com/FluentLenium/FluentLenium. This commit removes some code that never ran and a comment referring to FluentLenium.
@mkurz
Copy link
Contributor

mkurz commented Oct 9, 2025

fyi, we are replacing FluentLenium with Selenide:

(The referred PR is not up-to-date currently, I have much more locally currently which I still need to push after cleanup).

It should be quite easys to almost use the upcoming Play's Selenide integration as a more or less drop-in replacement.
Actually, it will be much nicer to configure Selenide.

As soon as I am done I will ping you and re-introduce the tests that you remove in this PR (if you don't mind).

@ioannakok
Copy link
Contributor Author

ioannakok commented Oct 9, 2025

fyi, we are replacing FluentLenium with Selenide:

(The referred PR is not up-to-date currently, I have much more locally currently which I still need to push after cleanup).

It should be quite easys to almost use the upcoming Play's Selenide integration as a more or less drop-in replacement. Actually, it will be much nicer to configure Selenide.

As soon as I am done I will ping you and re-introduce the tests that you remove in this PR (if you don't mind).

We actually don't need these tests, I have updated the PR description, so removing FluentLenium is a good opportunity to delete them. Thanks for offering to re-write them though!

@ioannakok ioannakok marked this pull request as ready for review October 9, 2025 13:44
@ioannakok ioannakok requested a review from a team as a code owner October 9, 2025 13:44
@ioannakok ioannakok merged commit 7507768 into main Oct 9, 2025
9 checks passed
@ioannakok ioannakok deleted the remove-fluentlenium-unused-code branch October 9, 2025 14:30
@gu-prout
Copy link

gu-prout bot commented Oct 9, 2025

Seen on ADMIN-PROD (merged by @ioannakok 8 minutes and 30 seconds ago)

@gu-prout
Copy link

gu-prout bot commented Oct 9, 2025

Seen on FRONTS-PROD (merged by @ioannakok 9 minutes and 36 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove FluentLenium

4 participants