-
Notifications
You must be signed in to change notification settings - Fork 566
Remove FluentLenium #28277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove FluentLenium #28277
Conversation
The project is no longer maintained: https://github.com/FluentLenium/FluentLenium oe are removing FluentLenium because the project is no longer maintained. https://github.com/FluentLenium/FluentLenium. This commit removes some code that never ran and a comment referring to FluentLenium.
|
fyi, we are replacing FluentLenium with Selenide: (The referred PR is not up-to-date currently, I have much more locally currently which I still need to push after cleanup). It should be quite easys to almost use the upcoming Play's Selenide integration as a more or less drop-in replacement. As soon as I am done I will ping you and re-introduce the tests that you remove in this PR (if you don't mind). |
We actually don't need these tests, I have updated the PR description, so removing FluentLenium is a good opportunity to delete them. Thanks for offering to re-write them though! |
|
Seen on ADMIN-PROD (merged by @ioannakok 8 minutes and 30 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @ioannakok 9 minutes and 36 seconds ago)
|
Closes #28260
What does this change?
Checklist