convert api requests asking for "orderBy=oldest" to the correct value#4469
Merged
Conversation
|
Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, collections, media-api, kahuna (merged by @andrew-nowak 8 minutes and 44 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
There's a discrepancy between the search params shown and used by Kahuna, and what's expected in the grid API. One is
orderBy- the default (so not shown in the kahuna params) is upload date, from newest to oldest, which the API phrases as-uploadTime. Next is upload date from oldest to newest; kahuna shows this as&orderBy=oldest; but the media API requiresuploadTime.We've had a handful of errors from the media-api from someone trying to order on "oldest", instead of "uploadTime". After some digging I've found the culprit (a service which tries to convert kahuna search params into media-api queries), but rather than fix it there, it's a simple fix to do inside grid itself, to be more resilient to slightly-wrong but still understandable queries.
How should a reviewer test this change?
Make some API queries, ordering on "oldest" - you should get successful requests, instead of 500s. Also/alternatively, paste a grid URL where you've been ordering by "oldest" into pinboard (note not using the "add to pinboard" button, which already does the right thing).
How can success be measured?
Fewer 5xxs
Who should look at this?
Tested? Documented?