add telemetryUri to CSP connectSources#4502
Merged
Merged
Conversation
prout-bot
added
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
Seen-on-auth
Seen-on-kahuna
Seen-on-cropper
Seen-on-media-api
and removed
Pending-on-cropper
Pending-on-media-api
Pending-on-kahuna
Pending-on-auth
labels
|
Seen on auth, cropper, kahuna, media-api (merged by @twrichards 9 minutes and 41 seconds ago) Please check your changes! |
|
Seen on collections, usage (merged by @twrichards 9 minutes and 47 seconds ago) Please check your changes! |
prout-bot
added
Seen-on-usage
and removed
Pending-on-collections
Pending-on-usage
labels
prout-bot
added
Seen-on-collections
Seen-on-leases
Seen-on-thrall
and removed
Pending-on-leases
Pending-on-thrall
labels
|
Seen on thrall, leases (merged by @twrichards 9 minutes and 51 seconds ago) Please check your changes! |
prout-bot
added
Seen-on-image-loader
Seen-on-metadata-editor
and removed
Pending-on-image-loader
Pending-on-metadata-editor
labels
|
Seen on metadata-editor, image-loader (merged by @twrichards 9 minutes and 56 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Since we have the
telemetryUri(assuming its set) available inKahunaConfigalready, why not add it to the CSPconnect-srclist, rather than to configure that manually.How should a reviewer test this change?
Run grid locally (perhaps with fresh config, but with
links.telemetryUrispecifed), inspect with the network tab and see that theconnect-srcpart of content-security-policy header contains the telemetryUri.✅ TESTED in TEST (removed the telemetry URL from the
security.connectSourceslist but it still appears in the CSP when inspecting in the Network panel).How can success be measured?
Less manual config 🎉
Who should look at this?
Tested? Documented?