Improve PA credit parsing#4503
Merged
Merged
Conversation
andrew-nowak
force-pushed
the
an/improve-pa-credit-parsing
branch
from
d0f454c to
e371392
Compare
bryophyta
approved these changes
Jul 23, 2025
bryophyta
left a comment
bryophyta
left a comment
Contributor
There was a problem hiding this comment.
code and test cases look good to me 👍
prout-bot
added
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
Seen-on-auth
Seen-on-usage
Seen-on-image-loader
Seen-on-cropper
Seen-on-metadata-editor
Seen-on-thrall
and removed
Pending-on-cropper
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-usage
Pending-on-auth
Pending-on-thrall
labels
|
Seen on auth, usage, cropper, image-loader, metadata-editor, thrall (merged by @andrew-nowak 11 minutes and 56 seconds ago) Please check your changes! |
|
Seen on collections, leases, kahuna, media-api (merged by @andrew-nowak 12 minutes and 5 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Improves parsing of PA credits. Rather than replacing credit with "PA" wholesale, we extract the section which identifies PA, then place "PA" as the final part of the credit.
How should a reviewer test this change?
Ask @paperboyo very nicely to test this change.
How can success be measured?
Who should look at this?
Tested? Documented?