update ads settings #1464
Merged
update ads settings #1464
+16
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-nowak
added
the
maintenance
andrew-nowak
force-pushed
the
an/update-ads-settings
branch
2 times, most recently
from
57adc5e to
1ecd006
Compare
andrew-nowak
force-pushed
the
an/update-ads-settings
branch
from
1ecd006 to
5d2c076
Compare
Looks like yt api has moved on - breakPositions seems to be being ignored and not setting prerolls, and weve been asked to turn on postrolls too. Move to the adBreaks setting, setting pre and postrolls, and let yt set the midrolls when it adds the autogenerated breaks. Hopefully this helps
andrew-nowak
force-pushed
the
an/update-ads-settings
branch
from
5d2c076 to
689da62
Compare
lindseydew
approved these changes
Jan 27, 2026
|
Seen on PROD (merged by @andrew-nowak 7 minutes and 46 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Looks like the Youtube API has moved on -
breakPositionsseems to be being ignored and not setting prerolls, and we've been asked to turn on postrolls too. Move to theadBreakssetting, setting pre and postrolls, and let Youtube set the midrolls when it adds the autogenerated breaks.How to test
Tested on CODE - uploaded an over 8min video, turned it on and published with monetisation on and checked that all the settings we wanted to be enabled were enabled.
How can we measure success?
Less manual fiddling with monetisation settings for video uploaders.