-
Notifications
You must be signed in to change notification settings - Fork 5
feat(registration): Initial GuCDK defined infrastructure #1644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,648
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d60c85f to
1a2e2d4
Compare
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
a9853fd to
431c61c
Compare
b0a2621 to
2f3c13f
Compare
Co-authored-by: Julia <JuliaBrigitte@users.noreply.github.com>
Co-authored-by: Julia <JuliaBrigitte@users.noreply.github.com>
…used Co-authored-by: Julia <JuliaBrigitte@users.noreply.github.com>
The infrastructure isn't fully migrated yet, so scale to 0. Co-authored-by: Julia <JuliaBrigitte@users.noreply.github.com>
… CLI CDK uses a different naming scheme to Riff-Raff, therefore `cdk diff` will not find the existing stack by default. Configure the CFN stack name to ensure the CDK CLI uses the right stack.
2f3c13f to
3226d76
Compare
akash1810
approved these changes
Jan 27, 2026
Member
|
This is now on PROD. |
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR introduces the initial GuCDK defined infrastructure of the
registrationEC2 app. It is intentionally minimal1 as the intention is to ensure CI/CD to multiple ASGs is configured correctly.Note
As we're instructing Riff-Raff to expect multiple ASGs, this needs to be deployed dangerously whilst the second ASG does not exist so that the pre-flight checks are skipped.
In follow-up PRs, we'll add the IAM permissions, scaling policies, alarms and DNS configuration.
How to test
Deploy it, it should succeed and there should now be 2 ASGs tagged
App=registration,Stage=CODE.Footnotes
The new ASG is scaled to 0 and the new ALB does not have a certificate or CNAME associated with it. ↩