Starred messages #294
Draft
Starred messages #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederickobrien
force-pushed
the
starred
branch
3 times, most recently
from
6e125dc to
7630d6d
Compare
twrichards
force-pushed
the
starred
branch
2 times, most recently
from
b294532 to
28165b1
Compare
frederickobrien
force-pushed
the
starred
branch
from
02f3625 to
28792a8
Compare
twrichards
force-pushed
the
starred
branch
2 times, most recently
from
b5819f8 to
2adb73b
Compare
Co-Authored-By: Tom Richards <19289579+twrichards@users.noreply.github.com>
Co-Authored-By: Tom Richards <19289579+twrichards@users.noreply.github.com>
Co-Authored-By: Tom Richards <19289579+twrichards@users.noreply.github.com>
Co-Authored-By: Tom Richards <19289579+twrichards@users.noreply.github.com>
…lay at the top of Composer articles) Co-Authored-By: Tom Richards <19289579+twrichards@users.noreply.github.com>
Co-Authored-By: Tom Richards <19289579+twrichards@users.noreply.github.com>
Co-Authored-By: Tom Richards <19289579+twrichards@users.noreply.github.com>
frederickobrien
force-pushed
the
starred
branch
from
e8b1d86 to
9a36de2
Compare
Co-Authored-By: Tom Richards <19289579+twrichards@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PR: https://github.com/guardian/flexible-content/pull/4400
Co-Authored-By: @twrichards
It's common to see notes used in body copy of Composer for important messages between editorial colleagues that aren't supposed to be published, but with un-noting being a single click they sometimes are.
An ambition of Pinboard has long been to centralise discussions around single pieces of content, not least because of this potentially problematic use of notes.
What does this change?
This adds a new
isStarredcolumn to the item table with corresponding GraphQL schema change, updated queries, and a mutation for toggling the new flag on a given item (which triggers the existingonMutateItemsubscription).Introduced a new star icon toggle button beneath the user's avatar to indicate the starred status of messages and on toggle present a confirmation modal (similar to the delete item modal).
Takes over the rendering of the placeholders added in https://github.com/guardian/flexible-content/pull/4400 and lists all starred messages (with timestamp and author) alongside an explainer of the feature.
The result looks a bit like this:
How to test
Deploy this and https://github.com/guardian/flexible-content/pull/4400 to their respective CODE environments and create some starred message in CODE Composer (on any article tracked in Workflow CODE, otherwise you won't get starred messages).
How can we measure success?
Ultimately fewer notes published accidentally, and starred messages can connect to larger ongoing conversations around pieces of content.
Have we considered potential risks?
Decoupling editorial notes from body copy does create an opportunity to see one but not the other. If Pinboard were to stop working as expected these important messages may stop being visible to those who most need to see them.
However in the vast majority of cases the sticky positioning and starred background of starred messages makes it more likely that they'll be seen than notes that slip out of the viewport.
Accessibility