reduce unnecessary getItemCounts calls
#364
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrichards
force-pushed
the
reduce-AppSync-requests
branch
from
4483599 to
93f864b
Compare
twrichards
force-pushed
the
reduce-AppSync-requests
branch
from
93f864b to
8d145c1
Compare
twrichards
force-pushed
the
add-database-call-logging
branch
from
f2fbd69 to
1b60fa8
Compare
twrichards
force-pushed
the
reduce-AppSync-requests
branch
from
8d145c1 to
60d4475
Compare
twrichards
force-pushed
the
reduce-AppSync-requests
branch
from
60d4475 to
06be4ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite #363, #352 etc. we're still seeing occasional
The IAM authentication failed because of too many competing requestserrors and more generally request volumes todatabase-bridge-lambdavia AppSync are really quite spiky, which warranted searching for wasteful calls. This PR eliminates 3 types of wasteful call...getPinboardsByPathsfor paths it hasn't already looked-upgetItemCountsin workflows inline-mode, when the list of pinboardIds actually changesgetItemCountscall with empty list infrontsIntegration.tsxHere we expect no regression in functionality or timeliness of data (counts etc.) but a reduction in calls, ideally smoothing out the spiky request patterns currently and so hopefully eliminating those errors whilst also hopefully saving a little money on AppSync charges.