Split out notifications to standalone service #383
+1,117
−172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loops all users with a `webPushSubscription` and attempts to send a push with `null` payload (which service worker now ignores) in order to check expiry/validity of their subscription TODO actually mark this in the DB Co-authored-by: Frederick O'Brien <frederick.obrien@guardian.co.uk>
…isExpired: true` property to the `webPushSubscription` jsonb field in `User` table whenever we detect failure, and we return a new `isValidWebPushSubscription` property to the client for the `GetMyUser` query (alongside the existing `hasWebPushSubscription`) Co-authored-by: Frederick O'Brien <frederick.obrien@guardian.co.uk>
Co-Authored-By: Tom Richards <19289579+twrichards@users.noreply.github.com>
Co-Authored-By: Tom Richards <19289579+twrichards@users.noreply.github.com>
Co-Authored-By: Tom Richards <19289579+twrichards@users.noreply.github.com>
Co-Authored-By: Tom Richards <19289579+twrichards@users.noreply.github.com>
Co-Authored-By: Tom Richards <19289579+twrichards@users.noreply.github.com>
frederickobrien
force-pushed
the
notifications-heartbeat
branch
from
d7b5081 to
970c527
Compare
Co-Authored-By: Tom Richards <19289579+twrichards@users.noreply.github.com>
frederickobrien
force-pushed
the
notifications-heartbeat
branch
from
84d484c to
d24500b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
How to test
How can we measure success?
Have we considered potential risks?
Images
Accessibility