-
Notifications
You must be signed in to change notification settings - Fork 0
Migrate support-workers to use v2 promos table #7672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tomrf1
wants to merge
2
commits into
main
Choose a base branch
from
tf-v2-promos-workers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+27
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Size Change: -3.24 kB (-0.19%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
Contributor
tomrf1
commented
Jan 9, 2026
| "@aws-sdk/util-dynamodb": ^3.879.0 | ||
| "@guardian/prettier": ^2.1.5 | ||
| "@guardian/support-service-lambdas": "guardian/support-service-lambdas#5ee15d1f6f45239d89c0bb51aebbfd01a6bf02af" | ||
| "@guardian/support-service-lambdas": "guardian/support-service-lambdas#28402575ce9a9f1a786d4dbfb05a3593673d6500" |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO - update this to use the main branch once it's merged
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're migrating to a new promos tool, with a new Dynamodb table and a simplified schema.
The old tool/table is still in use. Data is currently being sync'd from the v1 table to the v2 table.
We now have equivalent functions for the v2 promos table, added here:
guardian/support-service-lambdas#3327
This PR updates support-workers to use the v2 functions.
This big change here is that instead of scanning the entire promos table we can now just fetch the promoCode that we're interested in.