Add SUPPORTER PLUS as a rate plan charge name which enables digital access to the Live app #3334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbrown1982
added
Work in progress
feature
paulbrown1982
force-pushed
the
authorise-supporter-plus-via-cas
branch
from
f8e2964 to
b191c49
Compare
paulbrown1982
changed the title
paulbrown1982
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
The S+ T&Cs page say that you can use a ‘Supporter ID’ to sign in, but it's looking like that's wrong from our testing. Therefore this PR adds a SUPPORTER PLUS as a rate plan charge which enables digital access to the Live app via the Subscription ID and last name.
The change also refactors some variable and method names to make the code more readable.
https://trello.com/c/HRFgME7A/896-add-supporter-plus-allowed-charge-name-to-the-cas-digital-subscription-auth-system
How to test
Make a POST request to the CODE version of
https://content-auth.guardian.co.uk/subsproviding a validsubscriberIdand last name.