Open
Conversation
…bdas to make sample easier to read, make code more modern/approachable to devs thinking about onions on mobile - Made changes so sample app/project can open and build in a modern Android Studio (Meerkat)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was reading through onionmobile.dev and saw the sample linked on the TorServices page. I saw that the code uses outdated + lengthy jave anonymous inner class syntax so switched it to lambdas to make it more appealing + readable to developers browsing the site.
Saw that the project wouldn't open (and then wouldn't build) in a modern android studio (meerkat) so updated config settings.