feat(browse): edit hovered document from a collection column#57
Merged
Conversation
The "e" keymap previously only edited a document when the active column was itself a document column. Now it also edits the highlighted document when hovering over it in a collection column, matching the d/R/c handlers. startEditCmd fetches the document data when not already loaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enow edits the highlighted document while hovering in a collection column, not just when inside a document column — matching the existingd/R/chandlers.startEditCmdfetches the document data when it isn't already loaded (the hovered-item case); the doc-column path is unchanged.Test plan
go build -o firestore .passesgo test ./...passesmake integration-testpasseseopens editor; hover a sub-collection → status message; inside a doc column → still edits