fix: update adding_new_models tutorial to use current API#1450
Open
octo-patch wants to merge 1 commit into
Open
fix: update adding_new_models tutorial to use current API#1450octo-patch wants to merge 1 commit into
octo-patch wants to merge 1 commit into
Conversation
Update the adding_new_models tutorial to use the current API: - Replace OrcaChat (TransformersChat subclass) with OrcaChatTemplate (ChatTemplate subclass) - Use models.Transformers with chat_template parameter instead of subclassing - Remove stale outputs and update explanations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1402
Problem
The
adding_new_models.ipynbtutorial uses the outdated API where custom model support was implemented by subclassingTransformersChat. This API no longer exists in v0.3.x.The old approach:
Solution
Update the notebook to use the current
ChatTemplateAPI:OrcaChat(TransformersChat)withOrcaChatTemplate(ChatTemplate)models.Transformers(..., chat_template=OrcaChatTemplate)to load with a custom templateUnsupportedRoleExceptionfor proper error handling on unsupported rolesTesting
The updated code is self-contained and follows the same pattern used in the existing guidance documentation and codebase (e.g.,
guidance/chat.py).