Add structs and logic to pass draft params in target request #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmoskal
reviewed
Mar 26, 2025
Member
mmoskal
left a comment
mmoskal
left a comment
There was a problem hiding this comment.
Looks good! Now on to the rust part?
| // these are only output tokens | ||
| uint32_t num_tokens; | ||
| int32_t const* tokens; | ||
| int32_t const* tokens; //c_resp.tokens = data.tokens.data(); |
| } | ||
|
|
||
| // If we have draft params build draft config | ||
| if (request->draft_params.draft_tokens && request->draft_params.logits_tensor.data_ptr) |
Member
There was a problem hiding this comment.
would probably make sense to make the logits_tensor optional here, so you can support PLD with the same code. I assume it's just a matter of not passing it to the ExternalDraftTokensConfig
Author
There was a problem hiding this comment.
makes sense, will do this in a new PR, merging these changes into another fork (Nate is working on some rust changes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.