-
Notifications
You must be signed in to change notification settings - Fork 15
feat: added user preference page issue#41 #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added user preference page issue#41 #45
Conversation
… on app load and reusable fern loader
…mmary_on_load fix: navigates to test summaries when fern ui loads guidewire-oss#46
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a user preference page that allows users to update their theme and timezone settings, manage preferred projects with pagination, and includes an animated loader that aligns with the Fern UI theme. Key changes include:
- The creation of a new user preference page with form controls, pagination, and project removal features
- Implementation of a provider to handle user preference-related API calls and cookie retrieval
- Addition of a reusable animated loader and updates to header components to support navigation to the preferences page
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
test/component/user-preference.test.tsx | Added tests for rendering, saving preferences, error handling, and actions |
src/utils/cookies.ts | Introduced a helper function to retrieve the user cookie |
src/providers/user-preference-provider.ts | Implemented API calls for updating and fetching user preferences |
src/pages/user-preference/user-preference.tsx | Built the user preference page with settings, pagination, and project actions |
src/pages/user-preference/user-preference-utils.tsx | Added utility functions for project filtering, saving preferences, etc. |
src/pages/user-preference/interface.ts | Defined interfaces for user preferences and project groups |
src/pages/user-preference/index.tsx | Re-exported the user preference page |
src/mocks/mock-preferrencePage-data.ts | Added mock data for user preferences and projects |
src/components/spinner/index.tsx | Implemented the animated loader spinner |
src/components/header/index.tsx | Updated header to include navigation to the preferences page |
src/App.tsx | Integrated user preference routes and loader initialization |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/providers/user-preference-provider.ts:4
- [nitpick] The user preference provider imports 'API_URL' from './testrun-provider', which might be confusing. Consider defining a dedicated API_URL constant for user preferences to improve clarity.
import {API_URL} from "./testrun-provider";
…to_tabs Fix/move left nav to tabs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mrge found 22 issues across 13 files. View them in mrge.io
@parthivvv : could you please rebase the code and also address the comments? Now that @sundarok's PR for preferences apis is merged, can we test this out end to end? |
Screen.Recording.2025-05-23.at.1.15.02.AM.mov