-
Notifications
You must be signed in to change notification settings - Fork 10
bug in folds; time-efficient voting strategy; variable number of channels and prototypes #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jgciudad
wants to merge
7
commits into
guidogagl:main
Choose a base branch
from
jgciudad:prototype_features
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
54f310b
initial mssv commit
9ab20c3
fs=100 in sleepyrat
d91f63b
bug in mssv emg; split mssv per lab;
7db31bd
more time-efficient voting strategy; support for variable number of c…
jgciudad 884c50b
bug in fold selection in eval and test sets
jgciudad b78d426
revert bugs from #51391e9
jgciudad 89bc2a1
Merge remote-tracking branch 'origin/new_mouse_datasets' into prototy…
jgciudad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When no specific fold is specified (fold=-1), a fold is sampled when the training dataset is created, and again when eval_dataset is created, leading to different folds in each.
I’ve changed the default fold to fold 0 when no fold is specified. I’ve done this everywhere in the code and removed random fold selection.