fix: set a fallback value for --root-height to prevent page zoom#96
Open
cxa wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cxa
changed the title
--root-height to avoid page zoom--root-height to prevent page zoom
Owner
|
@cxa thanks for the PR, however I couldn't identify an issue with the first video. Can you help me? |
Author
|
@guilhermerodz In first video, you can see after navigating back, the page zoomed in (compare with 3s and 8s). This is due to page rendering instantly before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title.
See demo below. This is due to, if input's font size is smaller than 16px, for accessibility reasons, iOS will zoom page to enlarge input. So we give a fallback font size with 16px for
--root-heightwhich input will use as its font size if--root-heightis not available yet.Without fix:
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-04-15.at.14.53.54.mp4
With fix:
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-04-15.at.14.55.29.mp4