Add a way to change player name#3
Open
Anhijkt wants to merge 6 commits intoguillaumebrunerie:mainfrom
Open
Conversation
Owner
|
Thank you for the pull request! I do agree it should be possible to change the player name, and that it should be stored in local storage. However, I think that the layout of the page should stay the same when asking for the player’s name. So I think it should reuse the existing mechanism and keep all the other components visible (windows/mobile inputs/etc.). I guess the A few other remarks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think that using localStorage for storing player name and game config might be better than rearranging current IDBFS tree. Also its might provide more flexibility options for using nethackweb as a lib alone.