fix(notifications): user notifications page rendered raw i18n keys + wrong type field (#308)

Found while QA-testing the community & notifications area (#291).

The student/shared notifications page (`/dashboard/notifications`) was
fully broken visually:

1. The entire `dashboard.student.notifications` i18n namespace was missing
   from en.json and es.json. Every label rendered as its raw key path —
   "dashboard.student.notifications.title",
   "dashboard.student.notifications.tabs.all", ".empty.none", etc. Added the
   complete namespace in both locales (title, description, tabs, empty,
   actions, toasts, priority, types).

2. `NotificationsClient` read `notification.notification.type`, but the
   joined `notifications` row exposes `notification_type` (there is no
   `type` column). The type badge therefore resolved to `undefined` and
   showed a raw `types.undefined` key. Switched to `notification_type` and
   guarded the lookup with `t.has()` so an unmapped type falls back to the
   raw value instead of leaking the key path.

Verified end-to-end as Alice Student (4 certificate notifications):
- en + es chrome fully translated (title/description/tabs/empty)
- priority badge → "High"/"Alta", type badge → "Certificate"/"Certificado"
- "Mark all as read" flips Unread 4→0 / Read 0→4 with the localized toast
- admin (no notifications) shows the proper empty state

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Author: guillermoscript

components/notifications-client.tsx

@@ -33,7 +33,7 @@ type UserNotification = {
     id: number
     title: string
     content: string
-    type: string
+    notification_type: string
     priority: string
   }
 }
@@ -207,8 +207,10 @@ export function NotificationsClient({ notifications: initialNotifications }: Not
                       >
                         {t(`priority.${notification.notification.priority}`) || notification.notification.priority}
                       </Badge>
-                      <Badge variant="outline" className={`text-xs ${getTypeColor(notification.notification.type)}`}>
-                        {t(`types.${notification.notification.type}`) || notification.notification.type}
+                      <Badge variant="outline" className={`text-xs ${getTypeColor(notification.notification.notification_type)}`}>
+                        {t.has(`types.${notification.notification.notification_type}`)
+                          ? t(`types.${notification.notification.notification_type}`)
+                          : notification.notification.notification_type}
                       </Badge>
                       <span className="text-xs text-muted-foreground">
                         {formatDistanceToNow(new Date(notification.created_at), {

docs/screenshots/community-notifications-291.gif

@@ -154,6 +154,51 @@
   },
   "dashboard": {
     "student": {
+      "notifications": {
+        "title": "Notifications",
+        "description": "Stay up to date with activity across your school.",
+        "tabs": {
+          "all": "All",
+          "unread": "Unread",
+          "read": "Read"
+        },
+        "empty": {
+          "title": "No notifications",
+          "none": "You don't have any notifications yet.",
+          "caughtUp": "You're all caught up!"
+        },
+        "actions": {
+          "markAllAsRead": "Mark all as read"
+        },
+        "toasts": {
+          "markAsReadSuccess": "Notification marked as read",
+          "markAsReadError": "Couldn't mark notification as read",
+          "markAllAsReadSuccess": "All notifications marked as read",
+          "markAllAsReadError": "Couldn't mark all as read",
+          "dismissSuccess": "Notification dismissed",
+          "dismissError": "Couldn't dismiss notification",
+          "error": "Something went wrong"
+        },
+        "priority": {
+          "low": "Low",
+          "normal": "Normal",
+          "high": "High",
+          "urgent": "Urgent"
+        },
+        "types": {
+          "info": "Info",
+          "success": "Success",
+          "warning": "Warning",
+          "error": "Error",
+          "alert": "Alert",
+          "certificate_issued": "Certificate",
+          "comment": "Comment",
+          "comment_reply": "Reply",
+          "exam_review": "Exam review",
+          "order_renewal": "Order renewal",
+          "subscription_renewal": "Subscription renewal"
+        }
+      },
       "title": "My Learning",
       "welcome": "Welcome back! Continue where you left off.",
       "enrolledCourses": "Enrolled Courses",

messages/en.json

@@ -154,6 +154,51 @@
   },
   "dashboard": {
     "student": {
+      "notifications": {
+        "title": "Notificaciones",
+        "description": "Mantente al día con la actividad de tu escuela.",
+        "tabs": {
+          "all": "Todas",
+          "unread": "No leídas",
+          "read": "Leídas"
+        },
+        "empty": {
+          "title": "Sin notificaciones",
+          "none": "Aún no tienes notificaciones.",
+          "caughtUp": "¡Estás al día!"
+        },
+        "actions": {
+          "markAllAsRead": "Marcar todas como leídas"
+        },
+        "toasts": {
+          "markAsReadSuccess": "Notificación marcada como leída",
+          "markAsReadError": "No se pudo marcar como leída",
+          "markAllAsReadSuccess": "Todas las notificaciones marcadas como leídas",
+          "markAllAsReadError": "No se pudieron marcar todas como leídas",
+          "dismissSuccess": "Notificación descartada",
+          "dismissError": "No se pudo descartar la notificación",
+          "error": "Algo salió mal"
+        },
+        "priority": {
+          "low": "Baja",
+          "normal": "Normal",
+          "high": "Alta",
+          "urgent": "Urgente"
+        },
+        "types": {
+          "info": "Información",
+          "success": "Éxito",
+          "warning": "Advertencia",
+          "error": "Error",
+          "alert": "Alerta",
+          "certificate_issued": "Certificado",
+          "comment": "Comentario",
+          "comment_reply": "Respuesta",
+          "exam_review": "Revisión de examen",
+          "order_renewal": "Renovación de pedido",
+          "subscription_renewal": "Renovación de suscripción"
+        }
+      },
       "title": "Mi Aprendizaje",
       "welcome": "¡Bienvenido de nuevo! Continúa donde lo dejaste.",
       "enrolledCourses": "Cursos Inscritos",