Adelle/obs pred indication - #3060
Draft
Adelle-Pitsas wants to merge 4 commits into
Draft
Conversation
# Conflicts: # src/Features/ERDDAP/Map/WLPlatformLayer.tsx
Member
|
Very cool! I think this is probably a bigger change than we want to try to get in today, especially before I have a better understanding on how the request pattern will change, and if we should do any work on Buoy Barn to help make sure it can be shown efficiently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This finally fixes the RLayers issue with not rendering the most recent/updated data being passed to the map component.
Fixes:
keyprop torLayerspoint so with any new rerenders, it creates a completely new component (and uses newest/recent color to reflect tides passing data)New functionality:
If we want to include this new functionality for upcoming deployment, we'll need to add a few things to the legend to symbolize the obs vs pred