Large graph back button - #4158
Conversation
|
@abkfenris now with link! |
| <div className="d-flex flex-row p-2 position-relative align-items-start justify-content-end justify-content-sm-center"> | ||
| <BackToPlatformButton className="d-flex position-absolute start-0 ps-0 bg-white border-0" /> | ||
| <h2 className="d-flex gap-2 align-items-center"> | ||
| {ts.data_type.long_name} {depth} <Info timeSeries={[ts]} id={index} startDate={startDate} /> | ||
| </h2> | ||
| </div> |
There was a problem hiding this comment.
Is that going to show up at every depth?
There was a problem hiding this comment.
Ya, this doesn't need to get repeated.
Especially when that might happen
There was a problem hiding this comment.
Good eye, it does. Probably prefer just one at the top then?
| <div className="d-flex flex-row p-2 position-relative align-items-start justify-content-end justify-content-sm-center"> | ||
| <BackToPlatformButton className="d-flex position-absolute start-0 ps-0 bg-white border-0" /> | ||
| <h2 className="d-flex gap-2 align-items-center"> | ||
| {ts.data_type.long_name} {depth} <Info timeSeries={[ts]} id={index} startDate={startDate} /> | ||
| </h2> | ||
| </div> |
There was a problem hiding this comment.
Ya, this doesn't need to get repeated.
Especially when that might happen
|
Team, I feel like I need to speak up for the back buttons of the world. This "Back" button IMHO (and my unsolicited opinion) ain't a back button. If anything, it's redundant since it mimics a click on he Last 24 Hours button. And to add insult to injury, it highlights the beast. Let's say your friends gave you this link cuz they were so impressed when they saw it at the DMAC, http://localhost:3000/platform/ca0101/observations/direction_of_sea_water_velocity. You can't believe your luck! You're so impressed, that you click on the Back link to see what other awesome parameters be on the menu. And you are left w/ . . . nada. Why is the internets always playing tricks on me? |
|
Well whether the back button is kept or not, I think it's in a better place now. Handled the long variable names eating the back button by stacking column on mobile regardless. Centering both the text and icon does seem to play oddly when the string is just the right length though. 
No more back button on all graphs ^^^ |
|
In spite of me being a Karen, if this is merge ready, what say ye? |
3 participants
@cgalvarino
#3884
Adds a back button to the large graph page. Takes you back to the "Last 24 hours" page. Things didn't fit well on mobile portrait mode so I pushed the graph heading all the way to the right and the back button all the way to the left.
Goal
Desktop
Mobile - landscape
Mobile - portrait
