Skip to content

Replace deprecated pkg_resources with importlib.resources for future setuptools compatibility #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seamile wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace deprecated pkg_resources with importlib.resources for future setuptools compatibility #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f066eb
update version
gumblex Oct 31, 2021
de92635
refactor: replace deprecated pkg_resources with importlib.resources
seamile Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@

setup(
name='zhconv',
version='1.4.2',
version='1.4.4',
description="A simple implementation of Simplified-Traditional Chinese conversion.",
long_description=LONGDESC,
author='Dingyuan Wang',
Expand Down
10 changes: 7 additions & 3 deletions zhconv/zhconv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,20 @@

"""
# Only Python3 can pass the doctest here due to unicode problems.
__version__ = '1.4.2'
__version__ = '1.4.4'

import os
import sys
import re
import json

try:
from pkg_resources import resource_stream
get_module_res = lambda *res: resource_stream(__name__, os.path.join(*res))
if sys.version_info >= (3, 9):
from importlib.resources import files
else:
from importlib_resources import files

get_module_res = lambda *res: files(__name__).joinpath(*res).open('rb')
except ImportError:
get_module_res = lambda *res: open(os.path.normpath(
os.path.join(os.getcwd(), os.path.dirname(__file__), *res)), 'rb')
Expand Down