Fix integration-suite put tests for writing relationships and sets#11
Open
sentientforest wants to merge 1 commit into
Open
Fix integration-suite put tests for writing relationships and sets#11sentientforest wants to merge 1 commit into
sentientforest wants to merge 1 commit into
Conversation
The getGun() function appears to instantiate a new Gun instance each time it is called. It is called in a beforeEach() block prior to each test and sets up the gun variable with the instance. However, in certain tests, getGun() is called separately midway through the test. This looks to cause the test to try to assert data in a different Gun instance than the data was written to prior in the test, leading to a test failure. Replacing the getGun() call in these tests with the gun variable instance that was setup in the beforeEach block appears to fix the issue and make the tests pass.
Contributor
|
@oakenclast : Thanks so much for fixing this up! I'll take a look soon and merge this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The getGun() function appears to instantiate a new Gun instance each time it is called.
It is called in a beforeEach() block prior to each test and sets up the gun
variable with the instance.
However, in certain tests, getGun() is called separately midway through the test.
This looks to cause the test to try to assert data in a
different Gun instance than the data was written to prior in the test,
leading to a test failure.
Replacing the getGun() call in these tests with the gun variable instance
that was setup in the beforeEach block appears to fix the issue and make
the tests pass.