Skip to content

Update mathwords.py #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update mathwords.py #25

wants to merge 1 commit into from

Conversation

Ligament
Copy link

@Ligament Ligament commented Nov 2, 2018

support Thailand.

gunthercox
gunthercox requested changes Nov 15, 2018
View reviewed changes
Copy link
Owner

@gunthercox gunthercox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall these changes look great. I left one small suggestion for a change that will need to be made before this can be merged.

mathparse/mathwords.py
'ร้อย': 100,
'พัน': 1000,
'หมื่น': 10000,
'แสน':100000,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'แสน':100000,
'แสน': 100000,

A space needs to be added after this :.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunthercox gunthercox gunthercox requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ligament @gunthercox