Allow configuring min/max displayable samples and drag slider #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a settings menu to allow configuring the min/max samples on screen. This lets us display more than 10,000 samples on screen. I had some lower frequency signals that I wanted to look at that I couldn't fit entirely on screen without messing with the sample frequency and even then it was tough to capture my whole signal.
Min/max sample limits come from the connected device, or are 10-10000 by default when disconnected.
Also added a tooltip to the samples on screen slider when dragging or hovering to show the number we're at.
And finally adds the ability to move the slider window by dragging it with the mouse in the preview view at the bottom.
https://imgur.com/a/7HR9dBu
Rebased onto latest version/v6_5, everything seems to be working nicely