Skip to content

Ignore edits#68

Open
bmagistro wants to merge 2 commits into
gustavkarlsson:masterfrom
bmagistro:ignore-edits
Open

Ignore edits#68
bmagistro wants to merge 2 commits into
gustavkarlsson:masterfrom
bmagistro:ignore-edits

Conversation

@bmagistro

Copy link
Copy Markdown
Contributor

There is probably a way to reuse more of the AppIntegrationTest without copying, but I wasn't sure how.

I would have liked the test to validate the response but I am not sure I understand how everything (validators specifically) links together. Some testing on a chat instance shows the desired behavior. On new messages containing a valid jira issue, the link is sent back. On edit of a message containing or having a valid jira issue added, no response is sent back.

@codecov

codecov Bot commented Mar 10, 2019

Copy link
Copy Markdown

Codecov Report

Merging #68 into master will decrease coverage by 3.59%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #68     +/-   ##
===========================================
- Coverage     88.12%   84.52%   -3.6%     
- Complexity      208      209      +1     
===========================================
  Files            39       40      +1     
  Lines           522      530      +8     
  Branches         35       36      +1     
===========================================
- Hits            460      448     -12     
- Misses           40       62     +22     
+ Partials         22       20      -2
Impacted Files Coverage Δ Complexity Δ
...trigger/configuration/RocketChatConfiguration.java 100% <100%> (ø) 8 <1> (+1) ⬆️
...chat/jira_trigger/validation/ValidationModule.java 100% <100%> (ø) 8 <2> (+1) ⬆️
...ketchat/jira_trigger/validation/EditValidator.java 80% <80%> (ø) 2 <2> (?)
...cketchat/jira_trigger/routes/DetectIssueRoute.java 26.66% <0%> (-42.23%) 4% <0%> (-3%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cd5c22...a30720c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant