-
Notifications
You must be signed in to change notification settings - Fork 0
removed old solc versions, use 0.8.x only instead #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe CI configuration has been updated to modify the Solidity compiler versions used in the testing job. The outdated versions ("0.4.25", "0.5.7", "0.6.12", "0.7.5") have been removed and replaced with the versions "0.8.10" and "0.8.25". Additionally, the experimental configuration flags related to versions "0.6.12" and "0.7.5" have been removed, while the experimental configuration for "windows-latest" remains unchanged. In the test suites, certain Solidity contract tests targeting older compiler versions were removed, and one test case was simplified by removing explicit version and configuration parameters. Changes
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (6)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
208-211: Retention of the Windows Experimental FlagThe matrix’s
includeblock still sets theexperimental: trueflag forwindows-latest. As per the PR summary, experimental configurations for outdated solc versions were removed while keeping the Windows flag unchanged. Please confirm that retaining this experimental flag for the current 0.8.x tests is intentional and that it doesn’t cause any unintended behavior.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/ci.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: Build Echidna on windows-latest
- GitHub Check: Build Echidna on ubuntu-latest
- GitHub Check: Build Echidna on macos-13
- GitHub Check: Build macOS (x86_64) binary
- GitHub Check: Build Linux (x86_64) binary
- GitHub Check: Build macOS (aarch64) binary
🔇 Additional comments (1)
.github/workflows/ci.yml (1)
206-207: Updated Solidity Compiler VersionsThe test matrix now only includes Solidity compiler versions
"0.8.10"and"0.8.25", which aligns perfectly with the PR objective to remove support for older solc versions. Please verify that any related scripts or configurations (e.g., those usingsolc-select) are fully compatible with these versions.
Removed old solc versions tests, keeping only 0.8.x
Summary by CodeRabbit