feat: handle checkJs property if set in tsconfig #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove eval function - add function to remove comments from json Signed-off-by: Tobias Kuppens Groot <[email protected]>
- add file ext for js,cjs,mjs files which would be used if checkJs flag has been set by tsconfig Signed-off-by: Tobias Kuppens Groot <[email protected]>
|
Same problem as in #71: I don't believe you have to check if At least that's what I did in my fork at Also kind of a duplicate of #55. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the
tsconfig.jsoncontains the propertycheckJs: true, javascript files are not checked by tsc-files since the files filters do ignore file extensions other thantsandtsx. However, sincecheckJsshould include all valid javascript file extensions, it is expected that it will respect the setting of thetsconfig.jsonand take the additional file extensionsjs,cjsandmjsinto account.